From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: domains code query |
Date: | 2006-08-14 23:50:04 |
Message-ID: | 26517.1155599404@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> domains.c contains the followng snippet in domain_in():
> else* *if* (my_extra->domain_type != domainType)
> domain_state_setup(my_extra, domainType, false,
> fcinfo->flinfo->fn_mcxt);
> We were just looking at this code (in the context of implementing enums) and wondered when this case might arise.
> Would it be when more than one domain is used in a table row? Or are we smarter than that?
I think it's just defensive programming. The logic was copied from
array_in which does something similar, but AFAIR there's not really
any code path which would feed differing input types to the same
function call within a single query execution. Still, since it takes
only an extra comparison or so to handle the scenario, why not?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-08-14 23:56:09 | Re: plpgsql and INSERT/UPDATE/DELETE RETURNING |
Previous Message | Andrew Dunstan | 2006-08-14 23:39:25 | domains code query |