Re: Extensions, this time with a patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions, this time with a patch
Date: 2010-10-20 14:46:53
Message-ID: 26464.1287586013@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> If the extensions manager is dependent on the assumption that a module's
>> name matches the name of the directory it's built in

> It is not. There's some magic for simple cases so that contrib mostly
> "works" with no editing, but of course, that's only mostly.

> The version Itakagi-San worked with had not a single change to the
> contrib sources,

I don't think that "no changes to the makefiles" is a requirement,
or even a wish-list item, for this. I think it's perfectly reasonable
for the makefile to have to specify the module name; far better that
than that we get the name by some "magic" or other.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-10-20 14:47:50 Re: Domains versus arrays versus typmods
Previous Message Alvaro Herrera 2010-10-20 14:46:09 Re: Extensions, this time with a patch