Re: (re)start in our init scripts seems broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: (re)start in our init scripts seems broken
Date: 2016-07-20 13:47:23
Message-ID: 26260.1469022443@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Wed, Jul 20, 2016 at 11:41 AM, Tomas Vondra
> <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>> Is there a reason why it's coded like this? I think we should use the pg_ctl
>> instead or (at the very least) check the postmaster return code. Also,
>> perhaps we should add an explicit timeout, higher than 60 seconds.

> c8196c87 is one reason.

I think that 8f5500e6b improved that situation. You still have to be
really careful when writing the init script that there not be more than
one postgres-owned shell process.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2016-07-20 13:53:09 Re: dumping database privileges broken in 9.6
Previous Message Kevin Grittner 2016-07-20 13:37:59 Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <