Re: PATCH: CreateComments: use explicit indexing for ``values''

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: richhguard-monotone(at)yahoo(dot)co(dot)uk
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: CreateComments: use explicit indexing for ``values''
Date: 2011-06-16 21:06:20
Message-ID: 26229.1308258380@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

richhguard-monotone(at)yahoo(dot)co(dot)uk writes:
> This patch makes the intent of each initialization clear by using the constants directly instead of in a comment, and has the effect of being able to verify each line on it's own. The original requires verification of the preceding i++'s.

Applied, along with changing update_attstats() using Alvaro's idea.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Radosław Smogura 2011-06-16 21:13:08 Re: Patch - Debug builds without optimization
Previous Message Tom Lane 2011-06-16 20:56:30 Re: Nested CASE-WHEN scoping