| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Kevin Grittner <kgrittn(at)ymail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Karsten Hilbert <Karsten(dot)Hilbert(at)gmx(dot)net>, "Hilbert, Sebastian" <Sebastian(dot)Hilbert(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [GENERAL] pg_upgrade ?deficiency |
| Date: | 2013-11-22 21:31:46 |
| Message-ID: | 26220.1385155906@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-11-22 13:07:29 -0800, Kevin Grittner wrote:
>> I'm not sure I understand. Could you give an example of what
>> you're concerned about?
> pg_dumpall first spits out global data (users, databases, tablespaces)
> and then invokes pg_dump for every single database. So I'd very strongly
> suspect that your patch will issue the CREATE ROLE etc. calls without
> unsetting default_transaction_readonly.
Yeah, that's what I was wondering about. I don't think pg_dumpall -g
invokes pg_dump at all, so how could that case work? Maybe it would
only fail if the postgres database is read-only, though. Try it with
default-read-only set in postgresql.conf instead of as a database
property.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Meyer | 2013-11-22 21:32:59 | Re: Scrolling/Updating Cursors |
| Previous Message | Kevin Wooten | 2013-11-22 21:27:41 | Re: Scrolling/Updating Cursors |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-11-22 21:34:18 | Re: [GENERAL] pg_upgrade ?deficiency |
| Previous Message | Andres Freund | 2013-11-22 21:19:04 | Re: [GENERAL] pg_upgrade ?deficiency |