From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Stephen R(dot) van den Berg" <srb(at)cuci(dot)nl> |
Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Data type OID numbers fixed? |
Date: | 2008-07-08 00:21:16 |
Message-ID: | 26081.1215476476@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Stephen R. van den Berg" <srb(at)cuci(dot)nl> writes:
> case 16: // _bool
> case 17: // _bytea
> case 18: // _char
> case 20: // _int8
> case 21: // _int2
> case 23: // _int4
> case 25: // _text
> case 142: // _xml
> case 829: // _macaddr
> case 869: // _inet
> case 1042: // _bpchar
> case 1043: // _varchar
> case 1700: // _numeric
> case 2950: // _uuid
> How large is the probability of these numbers ever changing?
Not very, but just on code readability grounds, you should use the
macros from pg_type.h instead of writing literal constants.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | David E. Wheeler | 2008-07-08 00:26:24 | Re: PATCH: CITEXT 2.0 |
Previous Message | Tom Lane | 2008-07-08 00:18:40 | Re: PATCH: CITEXT 2.0 |