Warning in new GIN code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Warning in new GIN code
Date: 2014-01-23 18:41:20
Message-ID: 25947.1390502480@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The rather ancient gcc on my HPUX box is complaining thusly about HEAD:

ginbtree.c: In function `ginPlaceToPage':
ginbtree.c:602: warning: control reaches end of non-void function

I would imagine this would happen on any compiler that doesn't recognize
the hint about elog(ERROR) not returning. Could we stick a dummy return
at the end?

}
else
+ {
elog(ERROR, "unknown return code from GIN placeToPage method: %d", rc);
+ return false; /* keep compiler quiet */
+ }
}

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-01-23 18:57:00 Re: Add CREATE support to event triggers
Previous Message Tom Lane 2014-01-23 18:36:45 Re: Case sensitive mode in windows build option