Re: narwhal and PGDLLIMPORT

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: narwhal and PGDLLIMPORT
Date: 2014-02-11 18:42:59
Message-ID: 25623.1392144179@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Craig Ringer <craig(at)2ndquadrant(dot)com> writes:
> For MSVC, here's a patch that makes gendef.pl emit DATA annotations for
> global var exports.

Committed.

> Also attached is a patch to make vcregress.pl produce a better error
> message when there's no build output, instead of just reporting that
> ".. is not a recognized internal or external command, operable program,
> or batch file"

I would've committed this, but I'm a bit hesitant about this part:

+ use 5.10.1;

Are we moving the goalposts on the Perl version needed, and if so how
far? I didn't question the "use 5.8.0" you added to gendef.pl, but
it disturbs me that this isn't the same.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-02-11 18:54:48 Re: [PERFORM] encouraging index-only scans
Previous Message Bruce Momjian 2014-02-11 18:41:46 Re: [PERFORM] encouraging index-only scans