| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Allow units to be specified in relation option setting value. |
| Date: | 2014-08-28 14:14:53 |
| Message-ID: | 25150.1409235293@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> The patch attached fixes pg_upgrade by putting quotes when generating
> reloptions and it passes check-world. I imagine that having quotes by
> default in the value of reloptions in pg_class is the price to pay for
> supporting units. If this is not considered as a correct approach,
> then reverting the patch would be wiser I guess.
Ugh. I'm not sure what the best solution is, but I don't think I like
that one.
Given that this patch broke both pg_dump and pg_upgrade, I think it should
be reverted for the time being, rather than applying a hasty hack.
Obviously more thought and testing is needed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-08-28 14:30:57 | Re: pgsql: Allow units to be specified in relation option setting value. |
| Previous Message | Michael Paquier | 2014-08-28 14:10:09 | Re: pgsql: Allow units to be specified in relation option setting value. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-08-28 14:14:54 | Re: re-reading SSL certificates during server reload |
| Previous Message | Tom Lane | 2014-08-28 14:12:19 | Re: re-reading SSL certificates during server reload |