| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Problem Observed in behavior of Create Index Concurrently and Hot Update |
| Date: | 2012-11-27 17:50:36 |
| Message-ID: | 25050.1354038636@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> So the idea would be to skip about-to-be-dropped indexes in
> RelationGetIndexList directly - we don't ever need to watch those, not
> even for HOT - because we only have the necessary knowledge there. The
> normal valid/ready checks will be done at the callsites of
> RelationGetIndexList(). But those checks can be done in a locked manner
> now.
Right.
> Are you already working on a fix? Or shall I work on an updated patch?
I'll work on it.
> I vote for introducing wrapper functions/macro to do the
> about-to-be-dropped check, its hard enough to understand as-is.
Meh. If it's only going to be done in RelationGetIndexList, I'm
not sure that a wrapper macro is worth the trouble. If we needed
the test in multiple places I'd agree, but what other spots do you
see?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-11-27 17:55:09 | Re: Problem Observed in behavior of Create Index Concurrently and Hot Update |
| Previous Message | Tom Lane | 2012-11-27 17:47:11 | Re: MySQL search query is not executing in Postgres DB |