| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH 04/16] Add embedded list interface (header only) |
| Date: | 2012-06-22 00:04:02 |
| Message-ID: | 25036.1340323442@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Geoghegan <peter(at)2ndquadrant(dot)com> writes:
> All of the less popular compilers we support we support precisely
> because they pretend to be GCC, with the sole exception, as always, of
> the Microsoft product, in this case MSVC.
This is nonsense. There are at least three buildfarm machines running
compilers that do not "pretend to be gcc" (at least, configure
recognizes them as not gcc) and are not MSVC either. We ought to have
more IMO, because software monocultures are dangerous. Of those three,
two pass the "quiet inline" test and one --- the newest of the three
if I guess correctly --- does not. So it is not the case that
!USE_INLINE is dead code, even if you adopt the position that we don't
care about any compiler not represented in the buildfarm.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2012-06-22 00:32:02 | Re: [PATCH 04/16] Add embedded list interface (header only) |
| Previous Message | Tom Lane | 2012-06-21 23:43:08 | Re: pg_dump and dependencies and --section ... it's a mess |