Re: Function array_agg(array)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ali Akbar <the(dot)apaan(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Function array_agg(array)
Date: 2014-10-11 15:28:58
Message-ID: 24748.1413041338@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ali Akbar <the(dot)apaan(at)gmail(dot)com> writes:
> So, can't we just set the typarray of array types to its self oid?

Seems dangerous as heck; certainly it would have side-effects far more
wide-ranging than just making this particular function work.

A safer answer is to split array_agg into two functions,
array_agg(anynonarray) -> anyarray
array_agg(anyarray) -> anyarray

I rather imagine you should do that anyway, because I really doubt
that this hack is operating quite as intended. I suspect you are
producing arrays containing arrays as elements, not true 2-D arrays.
That's not a direction we want to go in I think; certainly there are
no other operations that produce such things.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-10-11 16:45:24 Re: jsonb contains behaviour weirdness
Previous Message Ali Akbar 2014-10-11 14:57:38 Function array_agg(array)