| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Useless code in ExecInitModifyTable |
| Date: | 2017-06-22 02:53:25 |
| Message-ID: | 24719bd8-fe6a-15bc-f9b1-c5ac9e6c3c98@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/06/22 11:25, Etsuro Fujita wrote:
> On 2017/06/21 23:52, Robert Haas wrote:
>
>> You're right that there is a comment missing from the function header,
>> but it's not too hard to figure out what it should be. Just consult
>> the definition of ModifyTable itself:
>>
>> /* RT indexes of non-leaf tables in a partition tree */
>> List *partitioned_rels;
>
> I agree on that point, but I think it's better to add the missing comment
> for the create_modifytable_path argument, as proposed in [1].
Thanks for sharing that link. I was about to send a patch to add the
comment, but seems like you beat me to it.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-06-22 03:00:36 | Re: Pluggable storage |
| Previous Message | Andres Freund | 2017-06-22 02:52:21 | Re: pg_terminate_backend can terminate background workers and autovacuum launchers |