Re: Lots of FSM-related fragility in transaction commit

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Lots of FSM-related fragility in transaction commit
Date: 2011-12-08 15:35:05
Message-ID: 23864.1323358505@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> On 08.12.2011 08:20, Tom Lane wrote:
>> So this is really a whole lot worse than our behavior was in pre-FSM
>> days, and it needs to get fixed.

> This bug was actually introduced only recently. Notice how the log says
> "consistent recovery state reached at 0/5D71BA8". This interacts badly
> with Fujii's patch I committed last week:

You're right, I was testing on HEAD not 9.1.x.

> That was harmless until last week, because reachedMinRecoveryPoint was
> not used for anything unless you're doing archive recovery and hot
> standby was enabled, but IMO the "consistent recovery state reached" log
> message was misleading even then. I propose that we apply the attached
> patch to master and backbranches.

Looks sane to me, though I've not tested to see what effect it has on
the case I was testing.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-12-08 16:13:02 Re: pg_dump --exclude-table-data
Previous Message Pavel Stehule 2011-12-08 15:34:10 Re: review: CHECK FUNCTION statement