| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Claudio Freire <klaussfreire(at)gmail(dot)com>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "Jan Wieck" <jan(at)wi3ck(dot)info> |
| Subject: | Re: jsonb format is pessimal for toast compression |
| Date: | 2014-09-19 14:07:47 |
| Message-ID: | 23806.1411135667@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> Tom: You mentioned earlier that your patch fixes some existing bugs.
> What were they?
What I remember at the moment (sans caffeine) is that the routines for
assembling jsonb values out of field data were lacking some necessary
tests for overflow of the size/offset fields. If you like I can apply
those fixes separately, but I think they were sufficiently integrated with
other changes in the logic that it wouldn't really help much for patch
reviewability.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dev Kumkar | 2014-09-19 14:09:05 | Re: pg_multixact issues |
| Previous Message | Rahila Syed | 2014-09-19 14:05:35 | Re: [REVIEW] Re: Compression of full-page-writes |