| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Joachim Wieland <joe(at)mcknight(dot)de> |
| Cc: | Gregory Stark <stark(at)enterprisedb(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: guc patch: Make variables fall back to default values |
| Date: | 2007-03-13 15:08:52 |
| Message-ID: | 2377.1173798532@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Joachim Wieland <joe(at)mcknight(dot)de> writes:
> On Tue, Mar 13, 2007 at 10:19:54AM -0400, Tom Lane wrote:
>> Well, they *are* strings as long as they're "custom". Once a
>> DefineCustomFoo has been executed, there (should be) no difference
>> between a "custom" variable and a hard-wired one.
> The code in question is the only place that calls one of the
> DefineCustom*Variable functions. But those functions set
> var->group = CUSTOM_OPTIONS what makes variables look like custom variables
> defined via SQL or the config file but in reality they aren't. Hence the
> confusion of the type assertion.
My point here that you shouldn't be using var->group to make any
semantic choices. That's supposed to be a label for user convenience,
nothing else.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joachim Wieland | 2007-03-13 15:31:12 | Re: guc patch: Make variables fall back to default values |
| Previous Message | Joachim Wieland | 2007-03-13 15:05:39 | Re: guc patch: Make variables fall back to default values |