Re: Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>, Brendan Jurd <direvus(at)gmail(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle
Date: 2008-11-08 21:03:32
Message-ID: 23625.1226178212@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> ... Consider

> -1 1:00:00 flips the sign
> - 1 1:00:00 doesn't flip the sign
> -1 day 1:00:00 doesn't flip the sign
> -2008-10 1:00:00 flips the sign
> -2008-10 1 doesn't flip the sign
> -2008 years 1:00:00 doesn't flip the sign

> If the rule were that it never flipped the sign for non-SQL-spec input
> then I think that'd be okay, but case 4 here puts the lie to that.
> I'm also not entirely sure if case 2 is allowed by SQL spec or not,
> but if it is then we've got a problem with that; and even if it isn't
> it's awfully hard to explain why it's treated differently from case 1.

Actually case 2 is a red herring --- I now see that ParseDateTime()
collapses out the whitespace and makes it just like case 1. So never
mind that. Case 4 is still bogus though.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-11-08 21:08:58 Re: [PATCH] Recreate Missing WAL Directories (from TODO)
Previous Message Tom Lane 2008-11-08 20:50:14 Re: Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle