Re: Multiple uses of same internal function

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Multiple uses of same internal function
Date: 2006-12-14 18:42:04
Message-ID: 23314.1166121724@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> The opr_sanity test checks the following:
> -- Considering only built-in procs (prolang = 12), look for multiple uses
> -- of the same internal function (ie, matching prosrc fields). It's OK to
> -- have several entries with different pronames for the same internal function,
> -- but conflicts in the number of arguments and other critical items should
> -- be complained of. (We don't check data types here; see next query.)

> Is this a leftover from the V0 fmgr days, or why is this not to be done?
> In particular, using one C function to implement a group of overloaded
> functions with different numbers of arguments seems useful.

Sure, but it's also a very uncommon usage, so the test still seems a
good idea to me. If you want to introduce such a function, I'd just
mark it as an expected exception to the test ...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2006-12-14 19:31:33 Need PostgreSQL security geeks to answer questions
Previous Message Peter Eisentraut 2006-12-14 18:17:20 Re: Security leak with trigger functions?