From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: nodes/*funcs.c inconsistencies |
Date: | 2015-08-03 03:31:16 |
Message-ID: | 23156.1438572676@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> Noah,
>> A fresh audit found the attached problems new in 9.5[1]. Most are cosmetic
>> INT/UINT or field order corrections. The non-cosmetic changes involve
>> CustomPath, CustomScan, and CreatePolicyStmt. Feature committers, if the
>> existing treatments (ignore custom_plans/custom_paths fields; copy/compare
>> "cmd" string pointer as a scalar) were deliberate, please let me know.
> Thanks for the review. The change you have is correct for
> CreatePolicyStmt, at least. I imagine I confused it with polcmd, which
> is actually just a char.
> Barring objections, I'll change it to cmd_name after your commit, to
> reduce the chances of future confusion.
Both of you please keep in mind that these "cosmetic" changes are
initdb-forcing, at least if they affect node types that can appear
in stored rules.
That being the case, it would probably be a good idea to get them done
before alpha2, as there may not be a good opportunity afterwards.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2015-08-03 03:47:40 | Re: nodes/*funcs.c inconsistencies |
Previous Message | Noah Misch | 2015-08-03 02:20:12 | Re: nodes/*funcs.c inconsistencies |