| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Volkan YAZICI <yazicivo(at)ttmail(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Configurable Penalty Costs for Levenshtein |
| Date: | 2008-04-03 21:19:19 |
| Message-ID: | 22834.1207257559@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Volkan YAZICI <yazicivo(at)ttmail(dot)com> writes:
> Sorry for the delay, but the reply of Tom didn't reach me. I've modified
> the patch according to Tom's comments. I hope I am not too late.
Applied after considerable revision. This patch:
* introduced a memory stomp that was not there before (I strongly
recommend testing C code in an --enable-cassert build)
* added a user-visible feature without documenting it
* undid a conflicting patch that had been applied since your first version
* removed a number of useful comments from the code
I cleaned it up and applied anyway, but generally we expect a higher
quality standard for patches that are claimed to be ready to apply.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-03 21:34:42 | Re: psql \G command -- send query and output using extended format |
| Previous Message | daveg | 2008-04-03 21:00:12 | Re: psql command aliases support |