Re: pg_test_fsync crashes on systems with POSIX signal handling

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_test_fsync crashes on systems with POSIX signal handling
Date: 2013-03-18 03:10:48
Message-ID: 22388.1363576248@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Fri, Mar 15, 2013 at 03:05:54PM -0400, Tom Lane wrote:
>> The quick-and-dirty fix for this is to just copy pqsignal() into
>> pg_test_fsync, and use that instead of calling signal() directly.
>> I wonder though if we shouldn't move that function into libpgport.
>> Thoughts?

> Well, the Win32 signal handler is already in port, so moving the Unix
> one seems to make sense, i.e. the comment above pgsignal says:
> /* Win32 signal handling is in backend/port/win32/signal.c */

Done, though it was a bit more painful than I expected --- I seem to
have guessed completely wrong about where the portability hazards were.
Good thing we have a buildfarm.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message robins 2013-03-18 03:59:22 Patch to add regression tests for SCHEMA
Previous Message Robert Haas 2013-03-18 02:57:51 Re: [v9.3] OAT_POST_ALTER object access hooks