Re: [GENERAL] queriing the version of libpq

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: "Massa, Harald Armin" <chef(at)ghum(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] queriing the version of libpq
Date: 2010-12-16 16:07:56
Message-ID: 22010.1292515676@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> But it does outline that fact that it wouldn't suck to have a >function in libpq returning the version so that application can >check this at runtime - clearly it would also be useful when >being linked "through" something like psycopg2.

> Stuck in a local git branch. I've rebased on current and added docs,
> see attachment.

Ick. Please get rid of that extra version number. There is no reason
not to use PG_VERSION_NUM. The documentation needs further thought too:
grammar needs work, and the format of the result value is unspecified.

But perhaps we should first recheck the premise. Exactly how will this
function be useful? I don't believe it's usable in the form implied by
the documentation, namely

if (PQlibVersion() >= something)
... call PQspiffyNewFunction() ...
else
... do something else ...

because if you're trying to link against an older libpq, the link will
fail before you ever get to execute. So let's have a less implausible
use-case please.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Magnus Hagander 2010-12-16 16:12:13 Re: [GENERAL] queriing the version of libpq
Previous Message Dmitriy Igrishin 2010-12-16 16:00:39 Re: [GENERAL] queriing the version of libpq

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2010-12-16 16:08:22 default localtimestamp at time zone
Previous Message Dmitriy Igrishin 2010-12-16 16:00:39 Re: [GENERAL] queriing the version of libpq