Re: Bugs/slowness inserting and indexing cubes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Jay Levitt <jay(dot)levitt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Bugs/slowness inserting and indexing cubes
Date: 2012-02-08 20:36:45
Message-ID: 220.1328733405@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I guess. I think the compelling reason to do ambuildempty first is
> that it's fast. So might as well. I think you'e just going to end up
> hard-wiring the assumption that ambuild happens before ambuildempty,

Well, no, because I'm proposing that both functions throw this error.

> which doesn't seem any better than the other way around, but I don't
> care enough to argue about if you feel strongly about it.

What's ugly about this solution is the duplicative ereport calls. But
at least the ugliness is confined to its source, ie gist.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marti Raudsepp 2012-02-08 21:13:11 Re: [PATCH] Enable min/max optimization for bool_and/bool_or/every
Previous Message Tom Lane 2012-02-08 20:31:18 Re: [GENERAL] pg_dump -s dumps data?!