Re: usleep feature for pgbench

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: usleep feature for pgbench
Date: 2007-07-05 21:30:14
Message-ID: 21985.1183671014@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
> I think I've coded it in a way that if one doesn't use the \usleep
> command at all, it will never even call gettimeofday() and use a NULL
> timeout in select() as it used to.

Did you check that the observed performance for non-usleep-using scripts
didn't change? If this extra overhead causes a reduction in reported
TPS rates it would make it hard to compare older and newer tests.

Other than that I've got no objection to it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-07-05 21:49:39 Re: usleep feature for pgbench
Previous Message Tom Lane 2007-07-05 21:28:00 Re: Bgwriter strategies