Re: integrate pg_upgrade analyze_new_cluster.sh into vacuumdb

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: integrate pg_upgrade analyze_new_cluster.sh into vacuumdb
Date: 2014-01-11 02:22:31
Message-ID: 21713.1389406951@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Fri, Jan 10, 2014 at 08:15:53PM -0500, Tom Lane wrote:
>> Why would we change the operational procedure of "run this script
>> after pg_upgrade"? It just complicates life for users.

> If it is one command, why use a script? Just give them the command.

Because it won't necessarily always be just one command. I don't
think we need to complicate life for users (or even more, their
scripts) by making them actually read what pg_upgrade prints there.

The point of Peter's proposal is that the multi-step-database-analyze
process might be useful outside the context of pg_upgrade, so it's
worth extracting that as a utility. It doesn't follow that we need
to change the way users *of pg_upgrade itself* invoke the process.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-01-11 02:25:26 Re: Standalone synchronous master
Previous Message Tomas Vondra 2014-01-11 02:15:35 Re: GIN improvements part 1: additional information