| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: LATERAL |
| Date: | 2009-12-20 05:45:00 |
| Message-ID: | 21575.1261287900@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Yeah, this is grotty. It appears that the comment introducing
>> ExecReScan() is somewhat incorrect. It asserts that exprCtxt is used
>> only
> Sigh.
> ...is used only for index scans. However, it's actually also used for
> bitmap scans (both heap and index) and TID scans.
Yeah, the comment was probably correct when written.
> Also, there appears
> to be an effort by nodes that don't use exprCtxt directly to propagate
> down through the node tree, which doesn't seem to make much sense if
> this is only intended to be used on the inner side of a nestloop.
That's just dead code, which is a good thing because the coverage is
pretty incomplete.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James William Pye | 2009-12-20 06:45:07 | Additional SPI functions |
| Previous Message | Robert Haas | 2009-12-20 04:06:36 | Re: LATERAL |