| From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | coelho(at)cri(dot)ensmp(dot)fr |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, ishii(at)sraoss(dot)co(dot)jp, alvherre(at)alvh(dot)no-ip(dot)org, nagata(at)sraoss(dot)co(dot)jp, thomas(dot)munro(at)gmail(dot)com, m(dot)polyakova(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org, teodor(at)sigaev(dot)ru |
| Subject: | Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors |
| Date: | 2022-04-18 05:52:05 |
| Message-ID: | 20220418.145205.605857581027112433.t-ishii@sranhm.sra.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> One thing that this doesn't fix is that the existing text appears
>> to suggest that the "failures" column is something different from
>> the sum of the serialization_failures and deadlock_failures
>> columns, which it's obvious from the code is not so. If this isn't
>> a code bug then I think we ought to just drop that column entirely,
>> because it's redundant.
>
> Ok. Fine with me. Possibly at some point there was the idea that there
> could be other failures counted, but there are none. Also, there has
> been questions about the failures detailed option, or whether the
> reports should always be detailed, and the result may be some kind of
> not convincing compromise.
Attached is the patch to remove the column.
Best reagards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-remove-failures-column.patch | text/x-patch | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-04-18 05:52:56 | Re: PG DOCS - logical replication filtering |
| Previous Message | Amit Kapila | 2022-04-18 05:49:14 | Re: Stabilizing the test_decoding checks, take N |