Re: [PATCH] pgbench tap tests fail if the path contains a perl special character

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Raúl Marín Rodríguez <rmrodriguez(at)carto(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date: 2019-01-18 19:27:38
Message-ID: 201901181927.sbv5o72uu4cc@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Jan-18, Raúl Marín Rodríguez wrote:

> Hi,
>
> > Fun. But is that really the only place that fails?
>
> Yes, other than this it builds flawlessly.
>
> > This does not look right to me: glob has a different set of special
> > characters than regexes, no?
>
> The issue itself manifests in the grep call, not in glob, but I tried
> using `quotemeta` only for grep without success (probably because I didn't
> know how to properly call `quotemeta` over @logs.

Perhaps you can do
@quoted = map { quotemeta($_) } @logs;

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mitar 2019-01-18 19:32:02 Re: Feature: temporary materialized views
Previous Message Vik Fearing 2019-01-18 18:58:06 Re: [HACKERS] REINDEX CONCURRENTLY 2.0