| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Rewriting the test of pg_upgrade as a TAP test |
| Date: | 2017-04-14 12:24:18 |
| Message-ID: | 20170414122418.GC9812@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
> On Fri, Apr 14, 2017 at 8:03 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > Some of those were specifically left around to test those code paths.
> > I'm not sure if these were those or not though, Andrew was the one who
> > reviewed the various pg_dumpall calls to add --no-sync in places.
>
> Well, Andrew has pushed the patch I have written, and the calls of
> pg_dumpall in pg_upgrade use --no-sync. The ones intentionally left
> are in src/bin/pg_dump/t/002_pg_dump.pl.
Ok. :)
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-04-14 12:26:44 | Re: Letting the client choose the protocol to use during a SASL exchange |
| Previous Message | Michael Paquier | 2017-04-14 12:22:33 | Re: Rewriting the test of pg_upgrade as a TAP test |