Re: [HACKERS] Small issue in online devel documentation build

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL www <pgsql-www(at)postgresql(dot)org>
Subject: Re: [HACKERS] Small issue in online devel documentation build
Date: 2017-04-10 13:44:16
Message-ID: 20170410134416.GC9801@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On Mon, Apr 10, 2017 at 10:17:26AM +0200, Magnus Hagander wrote:
> didn't that that happened in the old docs, but I can use an href filter
> to do it only for docs of versions starting with '1' or saying 'devel'.
>
> That said, doing something like this would probably be cleaner. However, I
> think doing it based on href is a bad idea -- we're bound to silently break
> that somehow.
>
> What if we changed the <div id="docContent"> tag to be something like <div id=
> "docContent" class="post-10"> 
>
> Please suggest a better name -- but the idea being we add a class do it,
> conditionally for the docs of v10 and newer (which would include devel). That
> way that logic stays where it belongs, and the CSS just uses the information to
> style on.

While we could trigger on some special tag, it is best to trigger on
something the build system does anyway so that if someone builds pre-10
docs with the new build system, they get the same output. The attached
patch uses:

div.refnamediv h2 .refentrytitle

and "div.refnamediv" is only generated in the new build system.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

Attachment Content-Type Size
color.diff text/x-diff 361 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-04-10 14:03:46 Re: logical replication and SIGHUP
Previous Message Magnus Hagander 2017-04-10 13:07:16 Re: src/interfaces/libpq shipping nmake-related Makefiles

Browse pgsql-www by date

  From Date Subject
Next Message Peter Eisentraut 2017-04-11 03:06:11 Re: [pgsql-www] Small issue in online devel documentation build
Previous Message Magnus Hagander 2017-04-10 13:20:27 Re: Some broken software catalogue links to remove