Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump
Date: 2016-05-06 21:44:37
Message-ID: 20160506214437.GG10850@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom, all,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> If you like, you can try the @contrib_excludes addition that was mentioned
> before and see if that fixes it. But if it doesn't, it's time to cut our
> losses.

Alright, it certainly *appears* to be working. All of the Windows
buildfarm animals which have reported back since I added test_pg_dump to
that list have been green. There are still a few boxes outstanding, but
that seems like a good sign too- they failed pretty quickly before.

I'm saying all this because I have to step out for a couple of hours.
I'll keep an eye on it and will be around later tonight to revert the
tests if necessary, but I'm not going to complain if someone else
chooses to do so if those last few Windows boxes come back red again
before I'm around again.

Thanks!

Stephen

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-05-06 21:49:01 pgsql: Docs: fix alphabetization of table entries.
Previous Message Tom Lane 2016-05-06 21:43:04 pgsql: Docs: minor copy-editing for GSSAPI/SSPI authentication docs.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-05-06 21:48:51 Re: Reviewing freeze map code
Previous Message Joshua D. Drake 2016-05-06 21:39:57 Re: Reviewing freeze map code