| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <rhaas(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Move each SLRU's lwlocks to a separate tranche. |
| Date: | 2016-03-25 07:05:06 |
| Message-ID: | 20160325070506.56i5p7jzxwqfljm6@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2015-11-12 19:59:54 +0000, Robert Haas wrote:
> Move each SLRU's lwlocks to a separate tranche.
>
> This makes it significantly easier to identify these lwlocks in
> LWLOCK_STATS or Trace_lwlocks output. It's also arguably better
> from a modularity standpoint, since lwlock.c no longer needs to
> know anything about the LWLock needs of the higher-level SLRU
> facility.
>
> Ildus Kurbangaliev, reviewd by Álvaro Herrera and by me.
Before this commit the lwlocks were cacheline aligned, but that's not
the case anymore afterwards; afaics. I think that should be fixed? I
guess it'd be good to avoid duplicating the code for aligning, so maybe
we ought to add a ShmemAllocAligned or something?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-03-25 12:04:13 | Re: [COMMITTERS] pgsql: Move each SLRU's lwlocks to a separate tranche. |
| Previous Message | Tom Lane | 2016-03-25 00:45:38 | pgsql: Link libpq after libpgfeutils to satisfy Windows linker. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-03-25 07:08:41 | Re: Performance degradation in commit 6150a1b0 |
| Previous Message | Michael Paquier | 2016-03-25 06:11:07 | Re: Optimization for updating foreign tables in Postgres FDW |