From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: ALTER SYSTEM and ParseConfigFile() |
Date: | 2015-05-10 01:52:22 |
Message-ID: | 20150510015222.GO30322@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> Stephen Frost wrote:
> > * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> > > I think the code is OK, but yeah, this comment should be changed to
> > > reflect the idea that the function will append entries to an existing
> > > list of name/value pairs (and thus, that head_p/tail_p are not output
> > > but in/out parameters).
> >
> > I've pushed a fix for the comment to address this.
>
> This open-coded list thingy is pretty odd. I wonder if it'd be nicer to
> replace it with ilist. (Not for 9.5, of course.)
I have a feeling that much of the GUC machinery could be reworked; as
Jim mentioned up-thread, it might be possible to use memory contexts too
which would make a lot of it much cleaner, I believe.
Agreed that it's not for 9.5 though.
Thanks!
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2015-05-10 01:55:06 | Re: ALTER SYSTEM and ParseConfigFile() |
Previous Message | Alvaro Herrera | 2015-05-10 01:50:53 | Re: ALTER SYSTEM and ParseConfigFile() |