| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Subject: | Re: Using 128-bit integers for sum, avg and statistics aggregates |
| Date: | 2015-03-09 17:39:50 |
| Message-ID: | 20150309173950.GA30307@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 09, 2015 at 01:39:04PM +0100, Andreas Karlsson wrote:
> On 03/07/2015 07:18 PM, Petr Jelinek wrote:
>
> >What I am wondering is if those numeric_int16_* functions that also deal
> >with either the Int128AggState or NumericAggState should be renamed in
> >similar fashion.
>
> You mean something like numeric_poly_sum instead of numeric_int16_sum? I
> personally am not fond of either name. While numeric_int16_* incorrectly
> implies we have a int16 SQL type numeric_poly_* does not tell us that this
> is an optimized version which uses a smaller state.
Would it be simpler to write a separate patch to add an int16 SQL type
so that this implication is correct?
> The worst part of writing this patch has always been naming functions and
> types. :)
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2015-03-09 17:50:18 | Re: Object files generated by ecpg test suite not ignored on Windows |
| Previous Message | Andrew Gierth | 2015-03-09 17:37:44 | Re: Calling for a replacement committer for GROUPING SETS |