| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments |
| Date: | 2015-01-03 15:03:36 |
| Message-ID: | 20150103150336.GA15316@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-12-31 16:32:19 +0100, Andres Freund wrote:
> On 2014-12-05 16:18:02 +0900, Fujii Masao wrote:
> > On Fri, Dec 5, 2014 at 9:28 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > > So I think we just need to make pg_basebackup create to .ready
> > > files.
> >
> > s/.ready/.done? If yes, +1.
>
> That unfortunately requires changes to both backend and pg_basebackup to
> support fetch and stream modes respectively.
>
> I've attached a preliminary patch for this. I'd appreciate feedback. I
> plan to commit it in a couple of days, after some more
> testing/rereading.
Attached are two updated patches that I am starting to backport
now. I've fixed a couple minor oversights. And tested the patches.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-pg_string_endswith-as-the-start-of-a-string-help.patch | text/x-patch | 4.6 KB |
| 0002-Prevent-WAL-files-created-by-pg_basebackup-x-X-from-.patch | text/x-patch | 15.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-01-03 17:04:11 | Re: recovery_min_apply_delay with a negative value |
| Previous Message | Michael Paquier | 2015-01-03 12:59:06 | Re: recovery_min_apply_delay with a negative value |