| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Atri Sharma <atri(dot)jiit(at)gmail(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Mark Cave-Ayland <mark(dot)cave-ayland(at)ilande(dot)co(dot)uk>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Commitfest problems |
| Date: | 2014-12-18 18:37:50 |
| Message-ID: | 20141218183750.GN1768@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Josh Berkus wrote:
> So, then, I have a proposal for criteria for getting on the contributors
> list via patch review:
>
> - substantial, deep review of at least one patch (including detailed
> code review and possible corrections)
>
> - "functionality" reviews of at least 3 patches, including full
> write-ups (not just "it compiled, seems to work").
>
> Kibitz as you may, but please don't try to make these criteria more
> *complicated*, because there's no way we'll ever keep track.
The problem with complicated rules (which these, I think, already are)
is how to keep track of people that helps to which level. I make a
point of crediting reviewers and code contributors in my commit
messages, but can you tell which ones of the following guys should make
it to these lists? I yanked this text from my commit
73c986adde5d73a5e2555da9b5c8facedb146dcd:
Reviewed to varying degrees by Michael Paquier, Andres Freund, Robert
Haas, Amit Kapila, Fujii Masao, Jaime Casanova, Simon Riggs, Steven
Singer, Peter Eisentraut
I do agree that we need to give credit in some form, though. I'm just
saying can we please not put the responsibility on committers.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2014-12-18 18:44:13 | Re: Commitfest problems |
| Previous Message | Josh Berkus | 2014-12-18 18:28:04 | Re: Commitfest problems |