| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mark Dilger <hornschnorter(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIP patch for Oid formatting in printf/elog strings |
| Date: | 2014-12-11 20:46:03 |
| Message-ID: | 20141211204603.GQ1768@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> > The attached patch changes the type of chunk_seq to int32,
> > rather than changing the %d formatting. The other changes
> > are the same as in the previous patch.
>
> BTW, how are you finding these? If it's some automated tool, what?
> (If you're finding them by hand, I'm in awe of your scan rate.)
BTW if it's an automated tool, it might also improve by examining the
DatumGetFoo() macros. In the reorderbuffer.c code just fixed you can
see that chunk_seq is obtained by DatumGetInt32(), which was wrong to
assign to a value of type Oid.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2014-12-11 20:47:29 | Re: Commitfest problems |
| Previous Message | Bruce Momjian | 2014-12-11 20:41:51 | Re: 9.5 release scheduling (was Re: logical column ordering) |