From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Role Attribute Bitmask Catalog Representation |
Date: | 2014-12-06 16:50:39 |
Message-ID: | 20141206165039.GD25679@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
* Adam Brightwell (adam(dot)brightwell(at)crunchydatasolutions(dot)com) wrote:
> > I don't see any changes to the regression test files, were they
> > forgotten in the patch? I would think that at least the view definition
> > changes would require updates to the regression tests, though perhaps
> > nothing else.
>
> Hmmm... :-/ The regression tests that changed were in
> 'src/test/regress/expected/rules.out' and should be near the bottom of the
> patch.
Hah, looked just like changes to the system_views, sorry for the
confusion. :)
> > Overall, I'm pretty happy with the patch and would suggest moving on to
> > writing up the documentation changes to go along with the code changes.
> > I'll continue to play around with it but it all seems pretty clean to
> > me and will allow us to easily add the additiaonl role attributes being
> > discussed.
>
> Sounds good. I'll start on those changes next.
Great!
Thanks,
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2014-12-06 17:02:16 | Re: inherit support for foreign tables |
Previous Message | Adam Brightwell | 2014-12-06 16:07:54 | Re: Role Attribute Bitmask Catalog Representation |