From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, MauMau <maumau307(at)gmail(dot)com> |
Subject: | Re: The problems of PQhost() |
Date: | 2014-11-27 18:43:01 |
Message-ID: | 20141127184301.GB1215506@tornado.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote:
> On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > Sure. I'll first issue "git revert 9f80f48", then apply the attached patch.
> > Since libpq ignores a hostaddr parameter equal to the empty string, this
> > implementation does likewise. Apart from that, I anticipate behavior
> > identical to today's code.
>
> + fprintf(stderr, _("out of memory\n"));
>
> psql_error() should be used instead of fprintf()?
I copied what pg_malloc() would do. Either way seems reasonable.
> + if (host == NULL) /* can't happen */
>
> Is this comment true? ISTM that "host" can be NULL when the default socket
> directory is used, i.e., neither host nor hostaddr are supplied by the user.
Right; I will adjust accordingly. Thanks.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-11-27 19:20:43 | Marginal performance improvement: replace bms_first_member loops |
Previous Message | Tomas Vondra | 2014-11-27 18:24:11 | Re: [BUGS] BUG #12071: Stat collector went crasy (50MB/s constant writes) |