Re: Turning recovery.conf into GUCs

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Alex Shulgin <ash(at)commandprompt(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Turning recovery.conf into GUCs
Date: 2014-11-24 15:31:47
Message-ID: 20141124153147.GD31915@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-11-24 10:13:58 -0500, Stephen Frost wrote:
> * Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> > Stephen Frost wrote:
> > > * Amit Kapila (amit(dot)kapila16(at)gmail(dot)com) wrote:
> > > > What exactly you mean by 'disable postgresql.auto.conf', do you
> > > > mean user runs Alter System to remove that entry or manually disable
> > > > some particular entry?
> > >
> > > Last I paid attention to this, there was a clear way to disable the
> > > inclusion of postgresql.auto.conf in the postgresql.conf. If that's
> > > gone, then there is a serious problem. Administrators who manage their
> > > postgresql.conf (eg: through a CM system like puppet or chef..) must
> > > have a way to prevent other changes.
> >
> > Sigh, here we go again. I don't think you can disable postgresql.auto.conf
> > in the current code. As I recall, the argument was that it's harder to
> > diagnose problems if postgresql.auto.conf takes effect in some system
> > but not others.
>
> I don't buy this at all. What's going to be terribly confusing is to
> have config changes start happening for users who are managing their
> configs through a CM (which most should be..). ALTER SYSTEM is going to
> cause more problems than it solves.

I fail to see how this really has really anything to do with this
topic. Obviously ALTER SYSTEM isn't a applicable solution for this as HS
might not be in use or HS might not have reached consistency at that
point.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-11-24 15:32:47 Re: Turning recovery.conf into GUCs
Previous Message Stephen Frost 2014-11-24 15:29:56 Re: Turning recovery.conf into GUCs