Re: Add CREATE support to event triggers

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add CREATE support to event triggers
Date: 2014-11-07 15:45:18
Message-ID: 20141107154517.GP1791@alvin.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier wrote:

> Here are more thoughts among those lines looking at the current state of
> the patch 4 that introduces the infrastructure of the whole feature. This
> would make possible in-memory manipulation of jsonb containers without
> relying on a 3rd-part set of APIs like what this patch is doing with
> ObjTree to deparse the DDL parse trees.

Thanks for the thoughts. I have to say that I have no intention of
reworking the jsonb code. If somebody else wants to do the legwork and
add that API as you suggest, I'm happy to remove all the ObjTree stuff
from this patch. I don't expect this to happen too soon, though, so I
would instead consider committing this patch based on ObjTree. Later,
when somebody comes around to reworking jsonb, we can rip ObjTree out.

> This infrastructure would allow in-memory manipulation of jsonb containers.
> Containers that can then be easily be manipulated to be changed back to
> strings and for value lookups using key strings.

Honestly, I had hoped that the jsonb code would have already included
this kind of functionality. I wasn't too happy when I discovered that I
needed to keep the ObjTree crap. But I don't want to do that work
myself.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ross Reedstrom 2014-11-07 15:51:35 row_to_json bug with index only scans: empty keys!
Previous Message Alvaro Herrera 2014-11-07 15:30:11 Re: Sequence Access Method WIP