| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: split builtins.h to quote.h |
| Date: | 2014-11-06 17:31:25 |
| Message-ID: | 20141106173125.GJ1791@alvin.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Julien Rouhaud wrote:
> I just reviewed this patch :
>
> * applies cleanly to master(d2b8a2c7)
> * all regression tests pass
>
> As it's only moving functions from builtins.h to quote.h and update
> impacted files, nothing special to add.
>
> It will probably break some user extensions using quote_* functions.
> Otherwise it looks ready to commit.
I thought the consensus was that the SQL-callable function declarations
should remain in builtins.h -- mainly so that quote.h does not need to
include fmgr.h.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G Johnston | 2014-11-06 17:49:36 | Re: Tweaking Foreign Keys for larger tables |
| Previous Message | Jim Nasby | 2014-11-06 17:28:03 | Re: Tweaking Foreign Keys for larger tables |