Re: TAP test breakage on MacOS X

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP test breakage on MacOS X
Date: 2014-10-31 05:04:31
Message-ID: 20141031050431.GC417926@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 30, 2014 at 10:49:33PM -0400, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > There are other issues. I am not going to enable this in the buildfarm
> > until the check test can work from a single install. It's insane for the
> > bin tests to take an order of magnitude longer than the main regression
> > suite.
>
> I think the installs as such aren't the only reason for the sucky
> performance. We need to also reduce the number of initdb cycles incurred
> by the TAP tests. It's useless for example that the pg_controldata test
> creates its very own $PGDATA rather than sharing one with other tests.
>
> This line of thought implies that the tests will become less independent
> of each other, which will probably result in them being a bit harder to
> maintain. Still, we are paying an awful lot of cycles for not much, as
> things stand at the moment.

One could memoize initdb within the suite. Call it once per distinct command
line, caching the resulting data directory. Copy the cached data directory
for each test desiring one.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-10-31 05:47:49 Re: WAL format and API changes (9.5)
Previous Message Amit Kapila 2014-10-31 04:42:40 Re: group locking: incomplete patch, just for discussion