Re: TAP test breakage on MacOS X

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP test breakage on MacOS X
Date: 2014-10-31 01:37:19
Message-ID: 20141031013719.GB13584@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-10-30 21:24:04 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2014-10-30 21:03:43 -0400, Tom Lane wrote:
> >> Meh. Right now, it's easy to dismiss these tests as unimportant,
> >> figuring that they play little part in whether the completed build
> >> is reliable. But that may not always be true. If they do become
> >> a significant part of our test arsenal, silently omitting them will
> >> not be cool for configure to do.
>
> > Well, I'm all for erroring out if somebody passed --enable-foo-tests and
> > the prerequisites aren't there. What I *am* against is requiring an
> > explicit flag to enable them because then they'll just not be run in
> > enough environments. And that's what's much more likely to cause
> > unnoticed bugs.
>
> Once they're at the point where they're actually likely to catch stuff
> of interest, I'll be all for enabling them by default.

Great. We already are at that point due to the pg_basebackup
tests.
If we slightly extend it to also start up the newly made base backups we
will have the first minimal automated test of recovery...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2014-10-31 02:12:58 Re: CREATE IF NOT EXISTS INDEX
Previous Message Tom Lane 2014-10-31 01:24:04 Re: TAP test breakage on MacOS X