| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: detect custom-format dumps in psql and emit a useful error |
| Date: | 2014-10-24 10:23:14 |
| Message-ID: | 20141024102314.GH5790@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-10-24 07:18:55 -0300, Alvaro Herrera wrote:
> Jeevan Chalke wrote:
>
> > Regarding Directory Error:
> > ===
> > I strongly against the proposal. This patch changing error message to
> > something like this:
> > "psql:blah:0: Input path is a directory. Use pg_restore to restore
> > directory-format database dumps."
> >
> > So even though I accidentally provide a directory instead of a sql script
> > file when I have NO intention of restoring a dump, above message looks
> > weired. Instead current message looks perfectly fine here. i.e.
> > "could not read from input file: Is a directory"
> >
> > psql always expect a file and NOT directory. Also it is not necessarily
> > working on restoring a dump.
>
> Yeah, this patch is a lot more debatable than the other one. I have
> pushed the first one without changing the error message.
We could just test for toc.dat and then emit the warning...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | furuyao | 2014-10-24 10:24:59 | Re: pg_receivexlog --status-interval add fsync feedback |
| Previous Message | Alvaro Herrera | 2014-10-24 10:18:55 | Re: detect custom-format dumps in psql and emit a useful error |