Re: BUG #11335: an invalid prepare statement causes crash at log_statement = 'mod' or 'ddl'.

On Wed, Sep 17, 2014 at 05:10:52PM -0700, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2014-09-17 14:56:42 -0700, Tom Lane wrote:
> >> Yeah, on second thought I have doubts about the throw-error approach too.
> >> We've allowed this historically for a very long time, so I'm afraid we'd
> >> get a lot of pushback if we change the external behavior now.
>
> > I have a hard time believing this. Are we really believing that there's
> > a significant number of clients preparing whitespace?
>
> I don't know about "significant number", but the case is specifically
> called out as legal in the FE/BE protocol spec, for example here:
>
> Therefore, an Execute phase is always terminated by the appearance of
> exactly one of these messages: CommandComplete, EmptyQueryResponse
> (if the portal was created from an empty query string), ErrorResponse,
> or PortalSuspended.
>
> If we change it, that's a protocol break, and I don't think that being a
> tad cleaner is sufficient argument for that.

Where are we on this?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +