Re: split builtins.h to quote.h

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: split builtins.h to quote.h
Date: 2014-10-11 21:46:22
Message-ID: 20141011214622.GT28859@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Bruce Momjian (bruce(at)momjian(dot)us) wrote:
> On Sat, Oct 11, 2014 at 05:19:27PM -0400, Noah Misch wrote:
> > On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote:
> > > Started a new thread to raise awareness.
> >
> > > Ref: this comes from
> > > http://www.postgresql.org/message-id/CAB7nPqR1iVd5r_QN_ngmkBOLQmAGBOsJ4WNPo8eybNn6WE_Kdw@mail.gmail.com
> >
> > Thanks. You can assume I'm -1 on every header split proposal not driving a
> > substantial compile duration improvement:
> >
> > http://www.postgresql.org/message-id/flat/20130917163056(dot)GA327792(at)tornado(dot)leadboat(dot)com
>
> Uh, I think clarity is also a reasonable reason to split headers.

I've only glanced at the actual patch, but I agree with Bruce.

Thanks,

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-10-11 22:01:58 Re: No toast table for pg_shseclabel but for pg_seclabel
Previous Message Fabrízio de Royes Mello 2014-10-11 21:46:19 Re: pg_dump refactor patch to remove global variables