| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Wait free LW_SHARED acquisition - v0.2 |
| Date: | 2014-10-08 17:23:44 |
| Message-ID: | 20141008172344.GV7043@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas wrote:
> On Wed, Oct 8, 2014 at 8:47 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > I don't see that as being relevant. The difference is an instruction or
> > two - in the slow path we'll enter the kernel and sleep. This doesn't
> > matter in comparison.
> > And the code is *so* much more readable.
>
> I find the slist/dlist stuff actually quite difficult to get right
> compared to a hand-rolled linked list. But the really big problem is
> that the debugger can't do anything useful with it. You have to work
> out the structure-member offset in order to walk the list and manually
> cast to char *, adjust the pointer, and cast back. That sucks.
As far as I recall you can get gdb to understand those pointer games
by defining some structs or macros. Maybe we can improve by documenting
this.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2014-10-08 17:39:56 | Re: Context lenses to set/get values in json values. |
| Previous Message | Andres Freund | 2014-10-08 17:20:16 | Re: Wait free LW_SHARED acquisition - v0.2 |