Re: Last Commitfest patches waiting review

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Peter Geoghegan <pg(at)heroku(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>, Rukh Meski <rukh(dot)meski(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Last Commitfest patches waiting review
Date: 2014-09-27 15:17:03
Message-ID: 20140927151703.GC5423@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-09-27 10:12:03 -0400, Tom Lane wrote:
> > Escaping from blocked send() by pg_terminate_backend().
>
> > I've had a look, but I'd like to have a second opinion on this.
>
> I concur with your opinion that this is scary as heck. We need multiple
> pairs of eyeballs if we're going to do anything in this area. In the long
> run though, I think pushing functionality into signal handlers is exactly
> backwards; we ought to be trying to go the other way.

I very much agree with that concern. The interactions are just
complicated.

I'm now refreshing my work to do all waiting in client communication via
latches. While far from trivial, I'm pretty sure that's the better
course in the long run.

I guess I'll post it in the other thread.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Singer 2014-09-27 16:11:16 Re: Replication identifiers, take 3
Previous Message Tom Lane 2014-09-27 14:12:03 Re: Last Commitfest patches waiting review