| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>, pgsql-hackers(at)postgresql(dot)org, furuyao(at)pm(dot)nttdata(dot)co(dot)jp |
| Subject: | Re: pg_xlogdump --stats |
| Date: | 2014-09-19 22:36:35 |
| Message-ID: | 20140919223635.GF13527@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-09-19 19:34:08 -0300, Alvaro Herrera wrote:
> Andres Freund wrote:
> > Hi,
> >
> > On 2014-09-19 15:39:37 +0530, Abhijit Menon-Sen wrote:
> > > I've attached the revised patch, split up differently:
> > >
> > > 1. Introduce rm_identify, change rm_desc, glue the two together in
> > > xlog.c
> > > 2. Introduce pg_xlogdump --stats[=record].
> >
> > I've pushed these after some fixing up.
>
> Hm, did you keep the static thingy you mentioned upthread (append_init
> which is duped unless I read wrong)?
Yes, I did.
> There's quite some angst due to pg_dump's fmtId() -- I don't think we
> should be introducing more such things ...
I don't think these two are comparable. I don't really see many more
users of this springing up and printing the identity of two different
records in the same printf doesn't seem likely either.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-09-20 03:54:51 | Re: Commitfest status |
| Previous Message | Alvaro Herrera | 2014-09-19 22:34:08 | Re: pg_xlogdump --stats |